Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added surface area to 3D Shapes Calculator #817

Merged
merged 10 commits into from
May 24, 2024
Merged

Added surface area to 3D Shapes Calculator #817

merged 10 commits into from
May 24, 2024

Conversation

debangi29
Copy link
Contributor

@debangi29 debangi29 commented May 24, 2024

Fixes Issue🛠️

Closes #750

Description👨‍💻

  1. Surface area calculator functionality added newly.

  2. 3D shapes calculator added which includes both surface area and volume calculator.

  3. 3D shapes calculator has two options in a drop-down menu to choose which calculator to use, and the calculators are merged accordingly.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

  1. I have tested the surface area calculator by checking its result using random values and cross verifying the results using officially available calculators on the internet.
    Also, negative length inputs has been avoided using a "Message".

  2. The functionality of the drop-down menu and submit button, along with the calculators checked.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

1. Added it to the home page:

image

2. The 3D shapes calculator:

image
image

3. The newly added surface area calculator by me

image

4. An example of calculation:

image

…e calculator; Surface area calculator functionality added newly
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @debangi29, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 24, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 37af600
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6650cc8741d1d200082548a0
😎 Deploy Preview https://deploy-preview-817--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 changed the title 3D shapes calculator added which includes both surface area and volume calculator; Surface area calculator functionality added newly Added surface area to 3D Shapes Calculator May 24, 2024
@Rakesh9100 Rakesh9100 merged commit 04215b0 into Rakesh9100:main May 24, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳🎉 @debangi29

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add surface area to 3D Shapes Calculator
2 participants