Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added point functionality to Basic Calculator #790

Conversation

shivangi-singhjha
Copy link
Contributor

Fixes Issue🛠️

Closes #634

Description👨‍💻

Added additional functionalities in the basic calculator for the point "."

Type of change📄

  • [] New feature (non-breaking change which adds functionality)

Checklist✅

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have added demonstration in the form of GIF/video file
  • [] I am an Open Source Contributor

Screenshots/GIF📷

Screenshot1
Screenshot2
Screenshot3

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shivangi-singhjha, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 22, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 7037883
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/664e62e4ef5b560008c80d73
😎 Deploy Preview https://deploy-preview-790--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Why have you added a new folder, you have to make changes in the existing one and fix the issue @shivangi-singhjha

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 24, 2024
@shivangi-singhjha
Copy link
Contributor Author

image

Sir but here its written to add your code in the newly created folder.
Sir I am getting confused. Kindly help sir🙏

@shivangi-singhjha
Copy link
Contributor Author

Sir @Rakesh9100 are the changes needed to be done in the existing Basic-Calculator Folder??

@Rakesh9100
Copy link
Owner

If you are adding a new calculator which is not present in the repository or website, then you have to create a new folder and follow the process.

But if an issue is raised to fix any changes to the existing calculator, then you have to make the changes to the same calculator folder files!
Hope this clears your confusion @shivangi-singhjha

@shivangi-singhjha
Copy link
Contributor Author

Ok Sir, Thank You!
I will correct the problem and generate a new PR

@shivangi-singhjha
Copy link
Contributor Author

Sir I have created a new PR #820
Kindly look into it 🙏

@Rakesh9100 Rakesh9100 changed the title Added additional functionalities in the basic calculator for the point . Add a point functionality to Basic Calculator May 25, 2024
@Rakesh9100 Rakesh9100 changed the title Add a point functionality to Basic Calculator Added point functionality to Basic Calculator May 25, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix point functionality in Basic Calculator
2 participants