Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Currency Calculator #787

Merged
merged 1 commit into from
May 24, 2024
Merged

Fixed Currency Calculator #787

merged 1 commit into from
May 24, 2024

Conversation

nagamukesh
Copy link
Contributor

@nagamukesh nagamukesh commented May 22, 2024

Fixes Issue🛠️

Closes #668

Description👨‍💻

I have noticed that the source code is available when I click on it.
Then, I checked the code and corrected the code which is responsible to route the HTML page properly
I also enhanced the website by adding some more currencies and options
Thnak you for the oppurtunity

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

Recording.2024-05-23.014547.mp4

The above shows the proper working of the site.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Copy link

netlify bot commented May 22, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 46182f0
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/664e52942195620008771b9b
😎 Deploy Preview https://deploy-preview-787--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nagamukesh, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100 Rakesh9100 changed the title currency calculator is now working Fixed the link to open Currency Calculator May 24, 2024
@Rakesh9100 Rakesh9100 merged commit 7e2819e into Rakesh9100:main May 24, 2024
5 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @nagamukesh

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task labels May 24, 2024
@nagamukesh nagamukesh changed the title Fixed the link to open Currency Calculator Fixed Currency Calculator Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the link to open Currency Calculator
2 participants