Fixed negative inputs in Logarithmic Calculator #774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue🛠️
Closes #630
Description👨💻
The base input while calculating the log should be positive and not 1. This issue has been fixed by inculcating the necessary changes in index.html file in the input tag and using validateBaseInput function.
Also the number whose log is being calculated should be positive which has been fixed on the similar lines by making changes in the input tag.
For more detailed information, review the changes made section.
Type of change📄
How this has been tested✅
Tested on my PC locally by entering the inputs that resulted in bug such as:-
The screenshot has been attached for the same which showcases that testing has been done and the code works fine as expected.
Checklist✅
Screenshots/GIF📷