Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cuban Prime Calculator #603

Merged
merged 9 commits into from
Feb 24, 2024
Merged

Conversation

AftabMankapure
Copy link
Contributor

Fixes Issue🛠️ #595

Closes #595

Description👨‍💻

Added cuban prime number calculator

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Cuban

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit ba12bdb
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/65da3f2f97815e000892f8a6
😎 Deploy Preview https://deploy-preview-603--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AftabMankapure
Copy link
Contributor Author

pls check this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AftabMankapure, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100
Copy link
Owner

  1. Add 1-2 lines about Cuban Prime and its formula below the heading.

  2. Show the solution process of the number which is Cuban when it is checked @AftabMankapure

@Rakesh9100 Rakesh9100 changed the title [Feature] Add Cuban Prime Calculator #595 Added Cuban Prime Calculator Feb 21, 2024
@AftabMankapure
Copy link
Contributor Author

check now i update it

@AftabMankapure
Copy link
Contributor Author

@Rakesh9100 pls check this PR now

@Rakesh9100
Copy link
Owner

When we are finding the cuban prime numbers in a range, the result should only show all the numbers and not the solutions of all.

Solutions should only be shown when we are checking a number for cuban @AftabMankapure

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 23, 2024
@AftabMankapure
Copy link
Contributor Author

@Rakesh9100 it is not possible to show solution for all number in range

@Rakesh9100
Copy link
Owner

Read the comment properly @AftabMankapure

@AftabMankapure
Copy link
Contributor Author

@Rakesh9100
pls check this now , now it ok as per required

newCuban

@Rakesh9100
Copy link
Owner

Merged 🎉 @AftabMankapure

@Rakesh9100 Rakesh9100 merged commit 3d843cb into Rakesh9100:main Feb 24, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion Hard Complex or challenging task JWOC JWOC Open Source Program and removed question 🤔 Further information is requested labels Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Hard Complex or challenging task JWOC JWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Cuban Prime Calculator
2 participants