Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added About Us Page #600

Merged
merged 11 commits into from
Feb 23, 2024
Merged

Added About Us Page #600

merged 11 commits into from
Feb 23, 2024

Conversation

SohanRC
Copy link
Contributor

@SohanRC SohanRC commented Feb 19, 2024

Fixes Issue🛠️

Closes #488

Description👨‍💻

Added About Us Page to the website ! Also I have added some animations to make this page more attractive and beautiful ! Moreover , I have made the whole page RESPONSIVE for mobile also.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested on local system and it worked perfectly !

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot 2024-02-20 033929

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SohanRC, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 096f4e8
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/65d8e900759f0b0008f85db8
😎 Deploy Preview https://deploy-preview-600--calcdiverse.netlify.app/assets/faq/faq
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 20, 2024

@Rakesh9100 Please review this PR !!

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

@Rakesh9100 Please review this PR !

@Rakesh9100
Copy link
Owner

Pls mention the correct issue number for this PR @SohanRC

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 21, 2024
@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

@Rakesh9100 I think the one who had opened this issue has closed the issue ! It is not showing !

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

@Rakesh9100 Should i open a issue ? Please reply !

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

@Rakesh9100 You had assigned me this issue but its not showing !! What should i do ? Should i open an issue ?

@Rakesh9100
Copy link
Owner

I am also thinking where that issue went as closing the issue by the contributor will show the issue closed but it is not showing only!!

No matters, just open a new issue and link it to this PR @SohanRC

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

I am also thinking where that issue went as closing the issue by the contributor will show the issue closed but it is not showing only!!

No matters, just open a new issue and link it to this PR @SohanRC

OK i am doing it now !

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

@Rakesh9100 I have opened the Issue #607

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 21, 2024

@Rakesh9100 I have opened the Issue #607

I have opened the issue ! Please check it !

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 22, 2024

@Rakesh9100 I have opened the Issue #607

I have opened the issue ! Please check it !

Please check it !

@Rakesh9100
Copy link
Owner

Pls work on these: @SohanRC

  1. Pls add the About button between Home and Calculators.
  2. Add an appropriate fa-icon as well.
  3. Add About menu button in every page navbar such as Contributors, FAQ and Contact pages.
  4. Remove all the animations from the About Page.

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 23, 2024

Pls work on these: @SohanRC

  1. Pls add the About button between Home and Calculators.
  2. Add an appropriate fa-icon as well.
  3. Add About menu button in every page navbar such as Contributors, FAQ and Contact pages.
  4. Remove all the animations from the About Page.

OK

@SohanRC
Copy link
Contributor Author

SohanRC commented Feb 23, 2024

@Rakesh9100 I have done all the changes ! Please review this PR now !

@Rakesh9100
Copy link
Owner

Good, Merged ✨ @SohanRC

@Rakesh9100 Rakesh9100 merged commit 5cbee6e into Rakesh9100:main Feb 23, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion Medium Moderate level implementation task JWOC JWOC Open Source Program and removed question 🤔 Further information is requested labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion JWOC JWOC Open Source Program Medium Moderate level implementation task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add About Us Page
2 participants