Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Love Compatibility Calculator #594

Merged
merged 8 commits into from
Feb 26, 2024
Merged

Conversation

pinak22dhir
Copy link
Contributor

@pinak22dhir pinak22dhir commented Feb 18, 2024

Fixes Issue🛠️

Closes #584

Description👨‍💻

Added Love Compatibility Calculator which takes the names, hobbies, and communication styles, and provides a delightful compatibility score for you both based on these aspects.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Compatibility

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @pinak22dhir, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Feb 18, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 383f8d1
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/65dcd4e5f0b2ac000849d3ce
😎 Deploy Preview https://deploy-preview-594--calcdiverse.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Rakesh9100 commented Feb 26, 2024

  1. Pls mention the issue number this PR closes.
  2. Include your calculator in main index.html file as well.
  3. Rename your folder to Love-Compatibility-Calculator and make the necessary changes.
  4. Add a Readme.md file inside your folder.

Work on these changes in this same PR and push the new commits @pinak22dhir

@pinak22dhir
Copy link
Contributor Author

@Rakesh9100 have a look,made changes

@Rakesh9100 Rakesh9100 changed the title P12 Added Love Compatibility Calculator Feb 26, 2024
@Rakesh9100
Copy link
Owner

Merged, Congrats on getting your PR merged to this repo under SWOC S4 🎉🎉 @pinak22dhir

@Rakesh9100 Rakesh9100 merged commit 42bc43d into Rakesh9100:main Feb 26, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion SWOC S4 SWOC Open Source Program Easy Low effort straightforward task labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy Low effort straightforward task SWOC S4 SWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Love Compatibility Calculator
3 participants