Added Fuel Cost Calculator #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Hansawani, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pls work on these changes in this same PR without closing this: @Hansawani
|
Rakesh9100
changed the title
|
okay i will revert back with the changes till the evening.
…On Sun, 18 Feb 2024 at 15:05, Rakesh Roshan ***@***.***> wrote:
Pls work on these changes in this same PR without closing this: @Hansawani
<https://github.com/Hansawani>
image.png (view on web)
<https://github.com/Rakesh9100/CalcDiverse/assets/73993775/9cb2811d-3864-4898-b7f6-07a91c2e4cfe>
1.
No other file changes should be done.
2.
Pls add your calculator in main index.html file.
3.
Mention the issue number this PR closes.
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3I2QC7BJKOYVMBLKEFVAZ3YUHDOPAVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGA2TGNRSHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hansawani
changed the title
|
please check the pr now. i have done the requested changes |
|
Pls work on first and third mentioned change @Hansawani |
|
I mentioned the issue number in the pr. What exactly do you mean by the
first change? I didn't understand that
…On Sun, 18 Feb, 2024, 19:04 Rakesh Roshan, ***@***.***> wrote:
Pls work on first and third mentioned change @Hansawani
<https://github.com/Hansawani>
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3I2QCYWUPCRLDSSCEO5FF3YUH7NZAVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGMZDOOBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Check this File Changes!! Why these many files modification are showing in this PR. Only files related to Fuel Cost Calculator should be added with no other modifications @Hansawani |
|
I haven't done any changes to the rest of the files except fuel cost
calculator. I don't know why it's showing so many modified files. Please
guide me on what exactly to do?
…On Sun, 18 Feb, 2024, 19:17 Rakesh Roshan, ***@***.***> wrote:
Check this File Changes
<https://github.com/Rakesh9100/CalcDiverse/pull/593/files>!!
Why these many files modification are showing in this PR. Only files
related to Fuel Cost Calculator should be added with no other modifications
@Hansawani <https://github.com/Hansawani>
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3I2QC32RDI3CGAKW3T4IXLYUIA55AVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGMZTAOJZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Please update me on my pr.
…On Sun, 18 Feb, 2024, 19:32 Hansawani Saini, ***@***.***> wrote:
I haven't done any changes to the rest of the files except fuel cost
calculator. I don't know why it's showing so many modified files. Please
guide me on what exactly to do?
On Sun, 18 Feb, 2024, 19:17 Rakesh Roshan, ***@***.***>
wrote:
> Check this File Changes
> <https://github.com/Rakesh9100/CalcDiverse/pull/593/files>!!
>
> Why these many files modification are showing in this PR. Only files
> related to Fuel Cost Calculator should be added with no other modifications
> @Hansawani <https://github.com/Hansawani>
>
> —
> Reply to this email directly, view it on GitHub
> <#593 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3I2QC32RDI3CGAKW3T4IXLYUIA55AVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGMZTAOJZGE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
These extra file changes are your previous PR commits that are showing up. Always update your forked repo branch by pulling the latest changes from the remote repo and then create your PR @Hansawani |
Rakesh9100
changed the title
|
Okay thank you for the update. I'll try to keep all this in mind the next
time. I'm sorry.
…On Mon, 19 Feb, 2024, 02:56 Rakesh Roshan, ***@***.***> wrote:
These extra file changes are your previous PR commits that are showing up.
Always update your forked repo branch by pulling the latest changes from
the remote repo and then create your PR @Hansawani
<https://github.com/Hansawani>
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3I2QC7XI23JBH6KZPVL47DYUJWYZAVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGQ2DSNZUGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Is my pr accepted for this issue?please update
…On Mon, 19 Feb, 2024, 08:56 Hansawani Saini, ***@***.***> wrote:
Okay thank you for the update. I'll try to keep all this in mind the next
time. I'm sorry.
On Mon, 19 Feb, 2024, 02:56 Rakesh Roshan, ***@***.***>
wrote:
> These extra file changes are your previous PR commits that are showing
> up. Always update your forked repo branch by pulling the latest changes
> from the remote repo and then create your PR @Hansawani
> <https://github.com/Hansawani>
>
> —
> Reply to this email directly, view it on GitHub
> <#593 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A3I2QC7XI23JBH6KZPVL47DYUJWYZAVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJRGQ2DSNZUGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
Merged 🎉 @Hansawani |
Rakesh9100
added
Completed 🥳
|
Thankyou. Please update the leaderboard.
…On Fri, 23 Feb, 2024, 15:19 Rakesh Roshan, ***@***.***> wrote:
Merged 🎉 @Hansawani <https://github.com/Hansawani>
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3I2QCZ22TDVOF256SKWHZDYVBQZXAVCNFSM6AAAAABDN7HJYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRRGAYTSNJRHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue🛠️
Closes #504
Description👨💻
Fuel Cost calculator has been added which calculates the cost of the fuel based on the distance travelled, fuel efficiency and cost of the fuel. It has an attractive UI and is easy to understand for the user.
Type of change📄
How this has been tested✅
Tested locally.
Checklist✅
Screenshots/GIF📷