-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dark mode functionality to the website #588
Conversation
Added the changes needed for introducing the light mode for the website. Introduced the toggle switch in the navbar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Yuvraj960, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Any update on this PR @Yuvraj960 |
Work going on @Rakesh9100 , actually time gone for choosing the perfect colors for the font, found that. Now implementing on whole website. And for the animation of the toggle, I am looking for a JS file which will do this work for us. Will attach the screenshots tomorrow showing the progress of the Light mode in the PR |
Okay, carry on @Yuvraj960 |
@Rakesh9100, please view the changes. |
The animation which is added is lagging as you can also check the deploy preview. Pls implement a good toggling button as mentioned before.
|
@Rakesh9100, first of all very sorry for the indentation issue. I didn't know how to resolve it. Recording.2024-02-19.184128.mp4And can you please elaborate me, that what do you meant by the "good toggling button"? I am still stuck in this. |
Okay, leave the indentation part. I will see it. Animation change is lagging sometimes not every time. Change the toggling button means implement some buttons like for examples:
You can go with any one of these or any similar kind of button instead of using a simple toggle button. Hope this clears your doubt!! @Yuvraj960 |
Added the all new themed Dark-light theme switch button based on the design of sun and moon.
@Rakesh9100, I have made the new switch button, kindly check its implementation. I hope with the most recent commit I have done in the button, you like this type of presentation now. |
|
Ok @Rakesh9100 , I understand all changes you need in the website, as there are many changes to be done in the website, It will take time, but I ensure you, I will give my best. Kindly assign me one of my another issues in this project, as I have to work on them also along with this issue in progress. |
Sure @Yuvraj960 |
Are you working @Yuvraj960 |
Yes @Rakesh9100 I am working, due to my weekend exam, I didn't replied |
@Rakesh9100, I need some help in this issue. Actually I am unable to understand the structure of the website. Can you please to some Favour for me. I am saying this only because I am unable to understand the file structure of the website, that which element of the website is contributing in which way to the pages of the website. I can design the light mode for all the pages and write the code for them also, only problem is with linking of those pages, that I am currently confused in, how to do it. |
@Rakesh9100 , please address me regarding this issue. |
Fixes Issue🛠️
Closes #515
Description👨💻
Added the changes needed for introducing the light mode for the website. Introduced the toggle switch in the navbar
Type of change📄
Checklist✅
Screenshots/GIF📷