Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tangent Formula Calculator and Height Unit option in BMI Calculator #1850

Merged
merged 10 commits into from
Dec 2, 2024

Conversation

isid555
Copy link
Contributor

@isid555 isid555 commented Aug 14, 2024

Fixes Issue🛠️

Closes #1861
Closes #1862

Description👨‍💻

  1. This PR enhances the functionality of the convertFeetToCm function by adding support for feet input. Previously, the function only accepted centimeter (cm) values, limiting its flexibility. With this update, users can now input a value in feet, and the function will convert it to total centimeters.

  2. The requirement is to integrate a new calculator into the existing project. The tan calculator should allow users to input a value (angle) and calculate its tangent.

  3. Changes in Binary Calculator
    Added Decimal Output:

A new parameter p has been introduced that allows the results to be displayed in decimal format in addition to binary. This enhances usability by providing users with a more familiar numerical representation.
Implemented Division Method:

Previously, the division operation was missing from the set of available operations. This method has now been implemented, enabling division of two binary inputs.
Added OR, AND, XOR Operators:

The binary operations set has been expanded to include the OR ,AND, XOR operators, allowing for more complex logical operations between two binary inputs.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Tangent Formula Calculator

image

Impact before changes

image

Impact after changes

BMI in cm

image

BMI in feet

image

Binary Calculator

image

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @isid555, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit d54a03b
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/674de09b29395b000932960d
😎 Deploy Preview https://deploy-preview-1850--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@isid555
Copy link
Contributor Author

isid555 commented Aug 14, 2024

@Rakesh9100 Kindly review my contribution

@isid555 isid555 changed the title Issue Title: Enhance convertFeetToCm Function to Include Centimeter… Feature Enhancement: Added Support for Feet Input in convertFeetToCm Function Aug 26, 2024
@Rakesh9100 Rakesh9100 changed the title Feature Enhancement: Added Support for Feet Input in convertFeetToCm Function Added Height Unit option in BMI Calculator Dec 2, 2024
@Rakesh9100 Rakesh9100 changed the title Added Height Unit option in BMI Calculator Added Tangent Formula Calculator and Height Unit option in BMI Calculator Dec 2, 2024
@Rakesh9100 Rakesh9100 merged commit e8abbc4 into Rakesh9100:main Dec 2, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added the Completed 🥳 PR successfully merged and issue resolved on completion label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @isid555

@Rakesh9100 Rakesh9100 added the Hard Complex or challenging task label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Hard Complex or challenging task
Projects
None yet
2 participants