Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the zero calculation in Pythagorean Theorem Calculator #1828

Merged
merged 1 commit into from
Aug 10, 2024

Conversation

srilekha279
Copy link
Contributor

@srilekha279 srilekha279 commented Aug 8, 2024

Fixes Issue🛠️

Closes #1811

Description👨‍💻

This pull request addresses the bug where the hypotenuse was incorrectly calculated when one of the sides was entered as zero. The updated implementation now correctly handles this case.

Type of Change📄

  • Bug fix (non-breaking change which fixes a bug)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

image

Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 99db0b6
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66b4d1d91c0a2b0008e4d487
😎 Deploy Preview https://deploy-preview-1828--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @srilekha279, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Nihal4777
Copy link

This PR is reviewed & can be merged.

@srilekha279
Copy link
Contributor Author

This PR is reviewed & can be merged.

Please assign level1 label

@Rakesh9100 Rakesh9100 changed the title Fixed incorrect hypotenuse calculation when side is zero Fixed the zero calculation in Pythagorean Theorem Calculator Aug 10, 2024
@Rakesh9100 Rakesh9100 merged commit 5973e44 into Rakesh9100:main Aug 10, 2024
5 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @srilekha279

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task labels Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Fix the zero calculation in Pythagorean Theorem Calculator
3 participants