Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more functionality in Fraction Calculator #1776

Merged
merged 5 commits into from
Aug 10, 2024

Conversation

Dark-S8uL
Copy link
Contributor

@Dark-S8uL Dark-S8uL commented Aug 3, 2024

Fixes Issue🛠️

Closes #1467

Description👨‍💻

Here is a summary of the changes made to the Fraction Calculator project:

  1. HTML Update :
  • Added a new input field in the form to display the decimal result.
  1. JavaScript Update :
  • Updated the solve function to calculate and display the decimal equivalent of the resulting fraction.
  • Included a check in the display function to alert if the result is not a real number.
  1. CSS Update :
  • Styled the new input field for the decimal result to match the existing input fields.
  1. README Update :
  • Updated the project description to include the new functionality of converting fractions to decimals and checking if the result is a real number.
  • Added detailed instructions on how to use the updated features.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Screenshot 2024-08-04 012829

Screenshot 2024-08-04 012801

Copy link

netlify bot commented Aug 3, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 3c6339e
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66b749b625aa5b0008d8da22
😎 Deploy Preview https://deploy-preview-1776--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Dark-S8uL, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Nihal4777
Copy link

@Rakesh9100 PR looks good.

@Dark-S8uL
Copy link
Contributor Author

@Nihal4777 @Rakesh9100 Please Merge this PR.

@Rakesh9100 Rakesh9100 changed the title Added More Functionality in Fraction Calculator Added more functionality in Fraction Calculator Aug 10, 2024
@Rakesh9100 Rakesh9100 merged commit a0417d6 into Rakesh9100:main Aug 10, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task labels Aug 10, 2024
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @Dark-S8uL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add more functionality in Fraction Calculator
3 participants