Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Work unit conversion in Unit Calculator #1752

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Added Work unit conversion in Unit Calculator #1752

merged 4 commits into from
Aug 8, 2024

Conversation

techy4shri
Copy link
Contributor

@techy4shri techy4shri commented Aug 1, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #1632

Description👨‍💻

  • HTML
    • Added a new dropdown menu in the form for unit conversion with the following options: Joule (J), ElectronVolt (eV), Calorie (cal), Kilocalorie (kcal), Foot-pound (ft-lb), and Kilowatt-hour (kWh).
  • JS
    • Added logic for conversion of unit for Work using International standards of conversion, with concise and efficient code.

Reason for Changes

These changes were made to provide users with the ability to convert the work value into various units of energy.

Testing

  • Verified that the dropdown menu appears correctly with the specified units.
  • Ensured that the dropdown styling is applied correctly and the box size is increased.

Please review the changes and let me know if any adjustments are needed.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Screenshot 2024-08-04 002959

@techy4shri
feat: Add unit conversion dropdown and enhance styling for work calcu…
2317017 
…lator

- Added a dropdown menu for unit conversion (Joule, ElectronVolt, Calorie, Kilocalorie, Foot-pound, Kilowatt-hour)
- Applied CSS styling to increase the size of the dropdown box
@netlify Netlify
Copy link

netlify bot commented Aug 1, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 66b8239
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66ae82c261906e00085fb686
😎 Deploy Preview https://deploy-preview-1752--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Aug 1, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @techy4shri, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Nihal4777
Copy link

Nihal4777 commented Aug 2, 2024 •
edited
Loading

@techy4shri Thank you for your contribution.

Actually, User inputs like dropdown should be above the calculate button.

Also, there is some issue with result div height. You can remove height css property to fix this.

image

@techy4shri
Copy link
Contributor Author

techy4shri commented Aug 2, 2024 •
edited by Rakesh9100
Loading

@techy4shri Thank you for your contribution.

Actually, User inputs like dropdown should be above the calculate button.

Also, there is some issue with result div height. You can remove height css property to fix this.

Okay,updating the code.

@techy4shri
Adjusted the size of the result box to ensure better wrapping.
39d1d7f 
Included the optionsinside the form instead of outisde in another form.
@techy4shri
Copy link
Contributor Author

Here are the changes @Nihal4777 :
image
image

@Nihal4777
Copy link

This PR is reviewed & can be merged.

@Rakesh9100
Copy link
Owner

I said you in the issue to add the Work conversion feature in the Unit Calculator and not the Work Calculator @techy4shri

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Aug 3, 2024
@techy4shri
Revert work calculator to original implementation and add unit conver…
8f2ae54 
…sion functionality to unit calculator

- Reverted the work calculator code to the original version.
- Enhanced the unit calculator by implementing unit conversion for work units (Joule, eV, calorie, kcal, kWh).
- Updated the dropdown menus and conversion factors accordingly.
@techy4shri
reverte work calculator to orginal.
66b8239
@techy4shri
Copy link
Contributor Author

@Rakesh9100 @Nihal4777 done. Apologies for the error.
image
Screenshot 2024-08-04 002959

@Rakesh9100 Rakesh9100 changed the title [Feature] Add Work unit conversion in Unit Calculator #1632 Added Work unit conversion in Unit Calculator Aug 8, 2024
@Rakesh9100 Rakesh9100 merged commit 9bb22f7 into Rakesh9100:main Aug 8, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task and removed question 🤔 Further information is requested labels Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @techy4shri

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@techy4shri techy4shri

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Work unit conversion in Unit Calculator
3 participants
@techy4shri @Nihal4777 @Rakesh9100