Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Atomic Composition Calculator #1669

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

bharat-c27
Copy link
Contributor

@bharat-c27 bharat-c27 commented Jul 17, 2024

Fixes Issue🛠️

Closes #712

Description👨‍💻

The calculator determines the number of protons, neutrons, and electrons in an atom based on its atomic number, atomic mass, and charge. It supports both neutral atoms and ions.

I have also handled the error validation.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Screenshot 2024-07-18 002317

Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit ccecd0e
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66a907870fcf1a0008fd823c
😎 Deploy Preview https://deploy-preview-1669--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bharat-c27, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@bharat-c27
Copy link
Contributor Author

Hello @Rakesh9100 can you please assign to me and add the necessary labels.

Thank you!!

@Nihal4777
Copy link

@Rakesh9100 This PR is reviewed & can be merged.

@bharat-c27
Copy link
Contributor Author

Hello @Rakesh9100 , I have completed the issue can you please assign this PR to me.
There are only 5 days left for GSSOC to get over.

Thank you!!

@Nihal4777
Copy link

@bharat-c27 Thank you for your contribution. Don't worry your PR will be merged within deadline.

@bharat-c27
Copy link
Contributor Author

@bharat-c27 Thank you for your contribution. Don't worry your PR will be merged within deadline.

Okay, Thank you @Nihal4777.

I was having a doubt. I have opened an issue on 12 Jun. I have referenced it 2-3 times, but I think @Rakesh9100 is busy so he did not assigned me the issue. I have completed my implementation work. I worked on it and hope to get merged before the deadline.

So can I raise a PR ?

Issue Link : #1317

@bharat-c27
Copy link
Contributor Author

Hello @Rakesh9100 please merge the PR as the deadline is tomorrow only.
And what should I do with the my issue #1317 which is been completed ?

@Rakesh9100 Rakesh9100 merged commit 7cca87a into Rakesh9100:main Jul 30, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @bharat-c27

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Atomic Composition Calculator
3 participants