Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Marks Percentage Calculator #1304

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

zalabhavy
Copy link
Contributor

@zalabhavy zalabhavy commented Jun 11, 2024

Fixes Issue🛠️

Closes #967

Description👨‍💻

A Marks to Percentage Calculator is a tool designed to convert the marks obtained in various subjects into a percentage.
It allows users to input the number of subjects and the marks obtained in each subject.
The calculator then sums up the total marks and computes the average percentage based on the number of subjects.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @zalabhavy, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 172b5db
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/666c7e43dab70700088c8d22
😎 Deploy Preview https://deploy-preview-1304--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zalabhavy
Copy link
Contributor Author

@Rakesh9100 Please check it and merge !

@Rakesh9100 Rakesh9100 changed the title Marks-to-Percentage Calculator added Added Marks Percentage Calculator Jun 11, 2024
@Rakesh9100
Copy link
Owner

Pls style and enhance the UI nicely and also remove the below header which is not needed, make the new commits in this same PR @zalabhavy

image

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 11, 2024
@zalabhavy
Copy link
Contributor Author

zalabhavy commented Jun 11, 2024

@Rakesh9100 Please check now and merge !
Now it looks good also it is responsive due to use of bootstrap.

@Rakesh9100
Copy link
Owner

image

Will not merge if UI is this much dull and simple @zalabhavy

@zalabhavy
Copy link
Contributor Author

@Rakesh9100 I try my best to add CSS and make it more attractive please check it now and please merge i give my lots of time to this.
image

@Rakesh9100
Copy link
Owner

I told you to remove this navbar, which is added unnecessarily @zalabhavy

image

@zalabhavy
Copy link
Contributor Author

@Rakesh9100 navbar removed please check it !

@Rakesh9100 Rakesh9100 merged commit d2c9ede into Rakesh9100:main Jun 14, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @zalabhavy

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task and removed question 🤔 Further information is requested labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Marks Percentage Calculator
2 participants