-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Prayer Time Calculator #1259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @samarsajad, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Please review my pull request @Rakesh9100 |
Can you please review my pull request so that i can work on other issue @Rakesh9100 |
Pls add your calculator folder inside |
I changed the directory. Please take a look @Rakesh9100 |
Why location is undefined, and do this application use our location or uses the inputs given by the user @samarsajad |
It uses the person's location. I couldn't solve the location undefined part. It takes user's input as well but also uses location @Rakesh9100 |
Either it will use our input or the location that the user allows to the browser, so see to this and also try to fix the undefined part @samarsajad |
The API I used had a parameter for city & Country. So I put those. But it also asks for the location when we use it. Can you please help me figure out what I am missing in this cause I tried so hard to figure out this undefined location part & didn't succeed @Rakesh9100 |
Okay, I will look over that bug afterward whenever I am free @samarsajad |
…r-Time-Calculator/assets/background.png
…tors/Prayer-Time-Calculator/assets/notification.mp3
Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @samarsajad |
Fixes Issue🛠️
Closes #1185
Description👨💻
A simple prayer time calculator that uses user's location to calculate the prayer timing.
Type of Change📄
Checklist✅
Screenshots/GIF📷