Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made CGPA Percentage Calculator responsive #1188

Merged
merged 12 commits into from
Jun 10, 2024
Merged

Conversation

agastya3636
Copy link
Contributor

@agastya3636 agastya3636 commented Jun 5, 2024

Fixes Issue🛠️

Closes #838

Description👨‍💻

Make CGPA Percentage Calculator responsive by making changes in css.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

image

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @agastya3636, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 32ca14c
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6667369d7e931c0008e4a3da
😎 Deploy Preview https://deploy-preview-1188--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Pls fill all the details in the PR template properly for every PR such as Description👨‍💻, How this has been tested✅ @agastya3636

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 5, 2024
@Rakesh9100 Rakesh9100 changed the title Made CGPA calculator responsive Made CGPA Percentage Calculator responsive Jun 5, 2024
@agastya3636
Copy link
Contributor Author

@Rakesh9100 done

@Rakesh9100
Copy link
Owner

Description👨‍💻 is still empty, make the habit of filling all the details properly @agastya3636

@agastya3636
Copy link
Contributor Author

@Rakesh9100 Sorry for that from next time I will do properly

@agastya3636
Copy link
Contributor Author

@Rakesh9100 please review it

@Rakesh9100 Rakesh9100 merged commit 8fab65d into Rakesh9100:main Jun 10, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @agastya3636

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task and removed question 🤔 Further information is requested labels Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Make CGPA Percentage Calculator responsive
2 participants