Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darkmode Background changed #557

Merged
merged 5 commits into from
Feb 11, 2024
Merged

Darkmode Background changed #557

merged 5 commits into from
Feb 11, 2024

Conversation

SplinterSword
Copy link
Contributor

@SplinterSword SplinterSword commented Feb 10, 2024

Fixes Issue🛠️

Closes #549

Description👨‍💻

I have included 4 dark mode backgrounds for the website's dark mode. In my opinion dbg4.jpg is the best background which fits the vibe of the website perfectly.

Type of change📄

  • [] Changed the style of the website

How this has been tested✅

Tested on local system and it worked perfectly !!

Checklist✅

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have added demonstration in the form of JPG files
  • [] I am an Open Source Contributor

Screenshots/GIF📷

dbg4.jpg
image

dbg3.jpg
image

dbg2.jpg
image

dbg1.jpg
image

… best backgroun and fits the vibe of website the best.
Copy link

netlify bot commented Feb 10, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 4c96735
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/65c8936e120c3500083aa3e8
😎 Deploy Preview https://deploy-preview-557--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SplinterSword, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@SplinterSword SplinterSword changed the title I have included 4 darkmode backgrounds. In my opinion dbg4.jpg is the… Darkmode Background changed Feb 10, 2024
@Rakesh9100
Copy link
Owner

Pls mention the issue number and screenshot in the PR description @SplinterSword

@SplinterSword
Copy link
Contributor Author

SplinterSword commented Feb 10, 2024

Pls mention the issue number and screenshot in the PR description @SplinterSword

I made the changes you asked me to do. Is there anymore changes necessary ?

@Rakesh9100
Copy link
Owner

Good, Merged!! Congrats on getting your PR merged to this repo under JWOC 🎉🎉 @SplinterSword

@Rakesh9100 Rakesh9100 merged commit 63f0b6c into Rakesh9100:main Feb 11, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Easy Low effort straightforward task Completed 🥳 PR successfully merged and issue resolved on completion JWOC JWOC Open Source Program labels Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy Low effort straightforward task JWOC JWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Dark mode background change
2 participants