Enhanced the theme toggle icon design #1432
Conversation
✅ Deploy Preview for beautiify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @SSrushti-s, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
|
Just a single icon, include two icons for light and dark mode such as sun and moon @SSrushti-s |
|
are these both icon fine ? |
|
No, the first icon that you implemented was good, so accordingly you can choose other similar icon @SSrushti-s |
|
I did search the sun and moon pair which is similar to the icon but I could not find which could match the gradient hence I thought of choosing this both. So can you tell if these both are fine? @Rakesh9100 |
|
No, these icons don't go well with the website theme and seems blurry, can you search for some more, I am sure you will find it @SSrushti-s |
|
Then can I try using this and this? |
|
Looks good, make the commits, and will check the deploy preview @SSrushti-s |
|
@Rakesh9100 I have made the changes kindly check. |
|
Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @SSrushti-s |
Rakesh9100
added
Medium
Fixes Issue🛠️
Closes #1431
Description👨💻
I have changed the dark mode icon and added a hover effect to increase readability by increasing the brightness around it.
Type of Change📄
Checklist✅
Screenshots/GIF📷