Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Neumorphism Accordion component responsive #1414

Merged
merged 1 commit into from
Dec 22, 2024
Merged

Made Neumorphism Accordion component responsive #1414

merged 1 commit into from
Dec 22, 2024

Conversation

ThePhoenix08
Copy link
Contributor

@ThePhoenix08 ThePhoenix08 commented Dec 21, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #1410

Description👨‍💻

  • Fixed body to 16px font size standard as default
  • Fixed h1, accordion button and body font sizes
  • Added media query to handle mobile view font sizes
  • Reduced outer padding of the component on mobile view

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

Mobile View Desktop View
IPhoneSE_View IPhoneSE_View

@netlify Netlify
Copy link

netlify bot commented Dec 21, 2024 •
edited
Loading

✅ Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit b78f500
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/6766fdc133e7df0008169bf7
😎 Deploy Preview https://deploy-preview-1414--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Dec 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ThePhoenix08, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Rakesh9100 Rakesh9100 changed the title fix neo accordian responsiveness Made Neumorphism Accordion responsive Dec 22, 2024
@Rakesh9100 Rakesh9100 changed the title Made Neumorphism Accordion responsive Made Neumorphism Accordion component responsive Dec 22, 2024
@Rakesh9100 Rakesh9100 merged commit 200cd30 into Rakesh9100:main Dec 22, 2024
5 checks passed
@github-actions GitHub Actions
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @ThePhoenix08

@Rakesh9100 Rakesh9100 added Easy Low effort straightforward task Completed 🥳 PR successfully merged and issue resolved on completion KWOC KWOC Open Source Program labels Dec 22, 2024
@ThePhoenix08 ThePhoenix08 deleted the accordian-respo branch December 23, 2024 03:00
@ThePhoenix08
Copy link
Contributor Author

Thanks for promptly reviewing my PR and merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@ThePhoenix08 ThePhoenix08

Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy Low effort straightforward task KWOC KWOC Open Source Program
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] Make Neumorphism Accordion component responsive
2 participants
@ThePhoenix08 @Rakesh9100