Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made 404 Error Card component responsive #1413

Merged
merged 3 commits into from
Dec 22, 2024

Conversation

712Kunal
Copy link
Contributor

@712Kunal 712Kunal commented Dec 21, 2024

Fixes Issue🛠️

Closes #1412

Description👨‍💻

  • Added a media query to make the error card responsive for mobile devices. Specifically, adjusted the body padding to 50px when the screen width is 768px or less.
  • Adjusted the width and height of the body to take the whole portion of the screen, and also adjusted the alignment of the elements those who are in the body.

Type of Change📄

  • Style (non-breaking change which improves website style or formatting)
  • Responsiveness (non-breaking change which improves UI/UX on different screen sizes)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

On desktop mode -

image

On tablet mode -

image

On mobile mode -

image

Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 150aabb
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/67689e2fb8745400089f57b4
😎 Deploy Preview https://deploy-preview-1413--beautiify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @712Kunal, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@712Kunal
Copy link
Contributor Author

@Rakesh9100 please accept the PR if you didn't find any flaws in the issue as soon as possible, because the deadline of the mid evaluation is day after tomorrow only and before that I should have atleast 1 PR to be accepted.

@Rakesh9100 Rakesh9100 changed the title made the error card component fully responsive Made 404 Error Card component responsive Dec 22, 2024
@Rakesh9100 Rakesh9100 merged commit a3bcada into Rakesh9100:main Dec 22, 2024
4 checks passed
Copy link

Congrats, Your pull request has been successfully merged 🥳🎉 Thank you for your contribution to my project 🚀 Keep Contributing!! ✨ @712Kunal

@Rakesh9100 Rakesh9100 added Easy Low effort straightforward task Completed 🥳 PR successfully merged and issue resolved on completion KWOC KWOC Open Source Program labels Dec 22, 2024
@712Kunal 712Kunal deleted the error-card-responsive branch December 23, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy Low effort straightforward task KWOC KWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Make 404 Error Card component responsive
2 participants