Nodejs week3 #3
Nodejs week3 #3
Conversation
| query | ||
| .leftJoin("reservation", "meal.id", "=", "reservation.meal_id") | ||
| .select("meal.id", "meal.max_reservations", "meal.title") | ||
| .sum("reservation.number_of_guests as sum_of_guests") | ||
| .groupBy("meal.id", "meal.max_reservations", "meal.title") | ||
| .having("sum_of_guests", "<", knex.ref("meal.max_reservations")); | ||
| } else { | ||
| query | ||
| .leftJoin("reservation", "meal.id", "=", "reservation.meal_id") | ||
| .select("meal.id", "meal.max_reservations", "meal.title") | ||
| .sum("reservation.number_of_guests as sum_of_guests") | ||
| .groupBy("meal.id", "meal.max_reservations", "meal.title") | ||
| .having("sum_of_guests", ">=", knex.ref("meal.max_reservations")); | ||
| } |
There was a problem hiding this comment.
these two queries are almost the same. You can merge the two by using ternary conditional operator in the having condition?ifTrue:ifFalse
| if (title !== undefined) { | ||
| query.where("title", "like", `%${title}%`); //performing a partial match here | ||
| } | ||
| if (dateAfter !== undefined) { | ||
| query.where("when", ">", dateAfter); | ||
| } | ||
| if (dateBefore !== undefined) { | ||
| query.where("when", "<", dateBefore); | ||
| } | ||
| if (limit !== undefined) { | ||
| query.limit(limit); //Returns the given number of meals | ||
| } |
There was a problem hiding this comment.
you are checking if the values in the request are undefined, but what if they are not, but incorrect data types? Validate the values and then return proper responses to the user so they know how to formulate the request correctly :)
| mealsRouter.get("/:meal_id/reviews", async (req, res, next) => { | ||
| try { | ||
| const id = req.params.meal_id; | ||
| const reviewsForMeal = await knex("review").where("meal_id", id); | ||
| if (reviewsForMeal.length == 0) { | ||
| res.json({ message: "Meal not found" }); | ||
| } else { | ||
| res.json(reviewsForMeal); | ||
| } | ||
| } catch (error) { | ||
| next(error); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Almost there :) please check https://stackoverflow.com/questions/13366730/proper-rest-response-for-empty-table for how to handle this scenario.
| reservationsRouter.delete("/:id", async (req, res) => { | ||
| try { | ||
| const id = req.params.id; | ||
| await knex("reservation").where({ id: id }).del(); |
There was a problem hiding this comment.
what if the reservation with this id doesnt exist? I guess it would be good to tell the user :)
| reviewRouter.get("/", async (req, res, next) => { | ||
| try { | ||
| const allReviews = await knex("review"); | ||
|
|
||
| if (allReviews.length === 0) { | ||
| return res.status(404).json({ message: "No reviews found" }); | ||
| } | ||
|
|
||
| res.json(allReviews); | ||
| } catch (error) { | ||
| next(error); | ||
| } | ||
| }); |
There was a problem hiding this comment.
similar comment as in /reservations
https://stackoverflow.com/questions/13366730/proper-rest-response-for-empty-table
| }); | ||
|
|
||
| // Updates the review by id. | ||
| reviewRouter.put("/:id", async (req, res, next) => { |
Meal sharing endpoints implemented:
Added more parameters to the meals route.
Created the set of routes for reviews as well.