Remove a superfluous trait bound that broke non-totem-pole devices #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no requirement for the hal trait implementations (`InputPin`, `OutputPin`, `StatefulOutputPin`) to require a `PortDriverTotemPole`. In fact, the presence of this bound means non-totem-pole devices no longer have hal trait implementations. Drop the superfluous bound to make non-totem-pole devices work again. Fixes: e7712de ("feat: Update to embedded-hal 1.0.0") Reported-by: Thomas Riedler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no requirement for the hal trait implementations (
InputPin,OutputPin,StatefulOutputPin) to require aPortDriverTotemPole. In fact, the presence of this bound means non-totem-pole devices no longer have hal trait implementations.Drop the superfluous bound to make non-totem-pole devices work again.
Fixes: e7712de ("feat: Update to embedded-hal 1.0.0") (regression in 0.5.0)
Fixes: #33