Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13, Allow option descriptions to be used as HTML title attributes in Selects #24

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

STimothyDN
Copy link

Allow Overriding HTML title attributes for select options

Description

This PR introduces logic to the HarnessVueBootstrapSelect component that allows the user to specify an optional description attribute in the filter options. If a description attribute is not provided, the component will default to setting the HTML title attribute as the provided option label. If one is provided, the component will use that value as the provided option label.

The motivation behind this change is to accommodate scenarios where the user would want to display an alternative tooltip when hovering over an option in the select component.

@STimothyDN STimothyDN linked an issue Aug 26, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@hardingalexh hardingalexh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll get this merged and deployed

@hardingalexh hardingalexh merged commit 658afb1 into main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow option descriptions to be used as HTML title attributes in Selects
2 participants