Exp test patterns #15
Conversation
There was a problem hiding this comment.
I think you're on the right track with the scenarios you've created, but the transform functions are not adjusting the right parameters. See my inline comment on those functions.
Please also convert this to a Draft PR so we don't accidentally merge it. All experiment PRs should be Draft PRs. We just use the PR interface for code review; we don't ever end up merging the experiment branches.
|
@pzirali I corrected the transform functions. See the TODO comments for some places where you can fill in additional scenarios following the patterns of the ones I created. The delayed onset adjustment ended up being more complicated than I initially thought. Make sure to take a close look at that transform function and check my logic. Also, after you removed the sensitivity test scenarios, we still had the FQHC-specific baseline and implementation scenarios. Because we're messing with compliance rates in these scenarios, the FQHC-specific compliance rates won't be used, so we don't need separate scenarios for each FQHC in this experiment, just one scenario per testing pattern. |
…st and therefore not created in the scenarios dir
|
This looks good! Can you confirm that the experiment ran successfully? Once it has, we can go ahead and close this PR. |
|
Experiment did run successfully! Thanks Sandy.
From: Sandy Preiss ***@***.***>
Date: Thursday, March 14, 2024 at 16:01
To: RTIInternational/crcsim ***@***.***>
Cc: Praveen Zirali ***@***.***>, Mention ***@***.***>
Subject: Re: [RTIInternational/crcsim] Exp test patterns (PR #15)
This looks good! Can you confirm that the experiment ran successfully? Once it has, we can go ahead and close this PR.
—
Reply to this email directly, view it on GitHub<#15 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BCQ2CPJRPFG2R6AUJ6LME6TYYH6Z7AVCNFSM6AAAAABD2YKSN6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGMZDKMRUHA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Conditional Compliance for Test Patterns