Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy recent updates to production #345

Merged
merged 17 commits into from
Jul 11, 2024
Merged

Deploy recent updates to production #345

merged 17 commits into from
Jul 11, 2024

Conversation

AstridKery
Copy link
Contributor

This branch contains the following updates. I'd like these to be given a thorough review by someone other than Andy and I before we deploy:

  • remove pagination on project list page
  • add sorting to history table for fields not including medatada
  • add setting to project which allows people with "coder" permissions to see all labeled data (this setting can be changed in the update form)
  • allow for un-verification of data and lock label changes in the history table when something is verified

andykawabata and others added 17 commits June 12, 2024 09:25
@andykawabata
Remove project list pagination
fcda442
@andykawabata
Added setting to allow coders view all labels
832e8e0
@andykawabata
Added advanced settings update form
8d8e8ed
@andykawabata
Disable option when IRR used
c1802fa
@AstridKery
Merge pull request #333 from RTIInternational/dev_remove_project_pagi…
94a4b14 
…nation

Remove project list pagination
@AstridKery
Merge branch 'dev' into dev_allow_coder_view_labels
79b1a9f
@AstridKery
Merge pull request #338 from RTIInternational/dev_allow_coder_view_la…
e1147ff 
…bels

Add option to allow users with "coder" permissions to view labeling history of all users
@andykawabata
allow sorting across all data in history table
c57bf78
@andykawabata
add reverse sort for data
f964ede
@andykawabata
clean up
feab3c9
@AstridKery
add unverified
1944d7f
@AstridKery
update so verified data can't be changed in the history table
d433044
@AstridKery
swap verify to toggle verify
99ccc4c
@andykawabata
Improve sorting performance
451d463
@AstridKery
Merge pull request #343 from RTIInternational/validated_updates
39afa6c 
Add ability to un-verify data, lock changing verified labels
@AstridKery
merge dev into branch
5992bd2
@AstridKery
Merge pull request #340 from RTIInternational/history-sorting-update
b238b0c 
Allow sorting across all data in history table
@AstridKery AstridKery self-assigned this Jul 2, 2024
@michael-long88 michael-long88 self-requested a review July 10, 2024 19:18
michael-long88
michael-long88 approved these changes Jul 10, 2024
View reviewed changes
Copy link

@michael-long88 michael-long88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Tested out with a few different users and all of the behavior seems to match the code. Thanks for this!

@AstridKery AstridKery merged commit 866ed00 into deploy Jul 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-long88 michael-long88 michael-long88 approved these changes

Assignees

@AstridKery AstridKery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AstridKery @michael-long88 @andykawabata