Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PepperBridgeAbstract, DealabsBridge, HotUKDealsBridge, MydealsBridge] Streamlining Group Management #4336

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

sysadminstory
Copy link
Contributor

Since groups can change URLs, be created, or removed at the discretion of website administrators, maintaining a valid and functional list of groups is impractical.

Users can now enter the part of the URL that defines the group in a text field, rather than searching through a lengthy, likely outdated list.

The way the RSS feed title is retrieved had to be adjusted accordingly.

Titles are now cached for 15 days to avoid unnecessary website access and to prevent potential bot blocking.

Existing feeds will continue to work, as their parameters remain unchanged; only the method for inputting them has been modified.

…] Streamlining Group Management

Since groups can change URLs, be created, or removed at the discretion
of website administrators, maintaining a valid and functional list of
groups is impractical.

Users can now enter the part of the URL that defines the group in a text
field, rather than searching through a lengthy, likely outdated list.

The way the RSS feed title is retrieved had to be adjusted accordingly.

Titles are now cached for 15 days to avoid unnecessary website access
and to prevent potential bot blocking.

Existing feeds will continue to work, as their parameters remain
unchanged; only the method for inputting them has been modified.
…] Streamlining Group Management

Coding policy fixes
Copy link

github-actions bot commented Nov 19, 2024

Pull request artifacts

Bridge Context Status
Dealabs 1 Recherche par Mot(s) clé(s) (current) ✔️
Dealabs 1 Recherche par Mot(s) clé(s) (pr) ✔️
Dealabs 2 Deals par groupe (current) Bridge returned error 410! (20046)
Type: HttpException
Message: https://www.dealabs.com/groupe/abattants-wc-hot resulted in 410 Gone
Dealabs 2 Deals par groupe (pr) HTTP status 500 Internal Server Error
Type: ErrorException
Message: Undefined array key 1
Dealabs 3 Surveillance Discussion (current) ✔️
Dealabs 3 Surveillance Discussion (pr) ✔️
HotUKDeals 1 Search by keyword(s)) (current) ✔️
HotUKDeals 1 Search by keyword(s)) (pr) ✔️
HotUKDeals 2 Deals per group (current) ✔️
HotUKDeals 2 Deals per group (pr) HTTP status 500 Internal Server Error
Type: ErrorException
Message: Undefined array key 1
HotUKDeals 3 Discussion Monitoring (current) ✔️
HotUKDeals 3 Discussion Monitoring (pr) ✔️
Mydeals 1 Suche nach Stichworten (current) ✔️
Mydeals 1 Suche nach Stichworten (pr) ✔️
Mydeals 2 Deals pro Gruppen (current) ✔️
Mydeals 2 Deals pro Gruppen (pr) HTTP status 500 Internal Server Error
Type: ErrorException
Message: Undefined array key 1
Mydeals 3 Überwachung Diskussion (current) ✔️
Mydeals 3 Überwachung Diskussion (pr) ✔️

last change: Tuesday 2024-11-19 22:23:25

…] Streamlining Group Management

Fix wrong comment
…] Streamlining Group Management

Add Example values for Group context
@sysadminstory sysadminstory changed the title Pepper rationalize parameters [PepperBridgeAbstract, DealabsBridge, HotUKDealsBridge, MydealsBridge] Streamlining Group Management Nov 19, 2024
@dvikan
Copy link
Contributor

dvikan commented Nov 23, 2024

ok cool.

I want to deprecate loadCacheValue.

$this->cache should be used instead in my personal opinion. all bridges have access to this cache

@dvikan dvikan merged commit 2ee615e into RSS-Bridge:master Nov 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants