fix: rewrite and improve caching (#3594)

README.md

@@ -55,6 +55,10 @@ Alternatively find another
 
 Requires minimum PHP 7.4.
 
+```shell
+apt install nginx php-fpm php-mbstring php-simplexml php-curl
+```
+
 ```shell
 cd /var/www
 composer create-project -v --no-dev rss-bridge/rss-bridge
@@ -334,10 +338,11 @@ This is the feed item structure that bridges are expected to produce.
 
 ### Cache backends
 
-* `file`
-* `sqlite`
-* `memcached`
-* `null`
+* `File`
+* `SQLite`
+* `Memcached`
+* `Array`
+* `Null`
 
 ### Licenses
 

actions/ConnectivityAction.php

@@ -34,7 +34,7 @@ public function __construct()
     public function execute(array $request)
     {
         if (!Debug::isEnabled()) {
-            throw new \Exception('This action is only available in debug mode!');
+            return new Response('This action is only available in debug mode!');
         }
 
         $bridgeName = $request['bridge'] ?? null;
@@ -43,7 +43,7 @@ public function execute(array $request)
         }
         $bridgeClassName = $this->bridgeFactory->createBridgeClassName($bridgeName);
         if (!$bridgeClassName) {
-            throw new \Exception(sprintf('Bridge not found: %s', $bridgeName));
+            return new Response('Bridge not found', 404);
         }
         return $this->reportBridgeConnectivity($bridgeClassName);
     }
@@ -54,29 +54,25 @@ private function reportBridgeConnectivity($bridgeClassName)
             throw new \Exception('Bridge is not whitelisted!');
         }
 
-        $retVal = [
-            'bridge' => $bridgeClassName,
-            'successful' => false,
-            'http_code' => 200,
-        ];
-
         $bridge = $this->bridgeFactory->create($bridgeClassName);
         $curl_opts = [
-            CURLOPT_CONNECTTIMEOUT => 5
+            CURLOPT_CONNECTTIMEOUT => 5,
+            CURLOPT_FOLLOWLOCATION => true,
+        ];
+        $result = [
+            'bridge'        => $bridgeClassName,
+            'successful'    => false,
+            'http_code'     => null,
         ];
         try {
-            $reply = getContents($bridge::URI, [], $curl_opts, true);
-
-            if ($reply['code'] === 200) {
-                $retVal['successful'] = true;
-                if (strpos(implode('', $reply['status_lines']), '301 Moved Permanently')) {
-                    $retVal['http_code'] = 301;
-                }
+            $response = getContents($bridge::URI, [], $curl_opts, true);
+            $result['http_code'] = $response['code'];
+            if (in_array($response['code'], [200])) {
+                $result['successful'] = true;
             }
         } catch (\Exception $e) {
-            $retVal['successful'] = false;
         }
 
-        return new Response(Json::encode($retVal), 200, ['Content-Type' => 'text/json']);
+        return new Response(Json::encode($result), 200, ['content-type' => 'text/json']);
     }
 }

actions/DetectAction.php

@@ -45,7 +45,7 @@ public function execute(array $request)
             $bridgeParams['format'] = $format;
 
             $url = '?action=display&' . http_build_query($bridgeParams);
-            return new Response('', 301, ['Location' => $url]);
+            return new Response('', 301, ['location' => $url]);
         }
 
         throw new \Exception('No bridge found for given URL: ' . $targetURL);