Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] fix_vllm_moe_quant #341

Conversation

lihaoyang-amd
Copy link

@lihaoyang-amd lihaoyang-amd commented Dec 20, 2024

Detail:
Alibaba benchmark test script quantizes a float model using vllm by giving in the parameters --quantization fp8 and --kv_cache_dtype fp8.
They don't use quark quantized model,
When using the 'moe_final_v0.6.0_Nov19' to do benchmark test for mixtral 8*7B, we got garbage output.
After checking, it was found that it was caused by a code missing in the vllm/model_executor/layers/quantization/fp8.py (For moe model,the func fuse_shuffle and moe_padding were not executed if using vllm to quantize model, and If passed to the vllm a quantized model, the two func can be executed correctly without errors ).

@lihaoyang-amd lihaoyang-amd marked this pull request as ready for review December 20, 2024 04:06
@lihaoyang-amd lihaoyang-amd changed the title [fix] fix_vllm_quant [Fix] fix_vllm_moe_quant Dec 20, 2024
@gshtras gshtras deleted the moe_final_v0.6.0_Nov19_fix_dynamic_quant branch December 20, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant