New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to override PYTORCH_ROCM_ARCH inherited from the base image #321

Merged

gshtras merged 1 commit into main from optional_pytorch_arch

Dec 11, 2024

Collaborator

gshtras commented Dec 11, 2024

To use a base image that doesn't set this env, or to limit the build to a subset of architectures from the base image


          Option to override PYTORCH_ROCM_ARCH inherited from the base image

e0cdcda

gshtras requested a review from maleksan85

December 11, 2024 19:37

maleksan85 approved these changes

View reviewed changes

gshtras merged commit a1aaa74 into main

7 of 8 checks passed

gshtras deleted the optional_pytorch_arch branch

December 11, 2024 20:07

pramenku commented Dec 13, 2024 •

edited

Loading

@gshtras this PR is missed in ROCm-6.3 branch so just merged via #327 with slight change to unblock our Navi3x testing

Note: For ROCm6.3.x, we are asked to use vllm "ROCm-6.3" branch

PR for main branch, #328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet