Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rpd build arg #269

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Rpd build arg #269

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5caf6f0
Added build arg for RPD build to disable it until its build is fixed …
gshtras Nov 7, 2024
9583c66
Passing the arg to the final stage
gshtras Nov 8, 2024
635f574
Merge branch 'main' into rpd_build_arg
gshtras Nov 8, 2024
024b047
Merge branch 'main' into rpd_build_arg
gshtras Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions Dockerfile.rocm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ARG BUILD_PYTORCH="1"
# If "0", it is copied in from the local working directory.
ARG REMOTE_VLLM="0"
ARG USE_CYTHON="0"
ARG BUILD_RPD="1"

# -----------------------
# vLLM base image
Expand Down Expand Up @@ -252,12 +253,13 @@ RUN --mount=type=bind,from=export_pytorch,src=/,target=/install \
fi

RUN python3 -m pip install --upgrade huggingface-hub[cli]

RUN git clone -b nvtx_enabled https://github.com/ROCm/rocmProfileData.git \
ARG BUILD_RPD
RUN if [ ${BUILD_RPD} -eq "1" ]; then \
git clone -b nvtx_enabled https://github.com/ROCm/rocmProfileData.git \
&& cd rocmProfileData/rpd_tracer \
&& pip install -r requirements.txt && cd ../ \
&& make && make install \
&& cd hipMarker && python setup.py install
&& cd hipMarker && python setup.py install ; fi

# Install vLLM (and gradlib)
# Make sure punica kernels are built (for LoRA)
Expand Down