Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface proposal : pull request 2 #54

Open
wants to merge 3 commits into
base: rocm-4.3.x
Choose a base branch
from

Commits on Sep 21, 2021

  1. allow fine-grained control on several APIs

    Deleted a line that makes rocprof abort when using fine grained control one several APIs at a time. The parsing function in libtracer_tool.so that parses the input XML file that specifies the functions for which the user wants to activate the tracing callbacks seems to handle correctly cases where fine-grained control is used on several APIs. This line can be safely deleted.
    yoann-heitz committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    125e1b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Isolate flushing instructions for metrics

    Isolated flushing instructions into a wrapping function. The file descriptor used for flushing is the one that is globally defined and not the one stored in the context_entry_t object as it is always the one that is defined globally that is used. If using a globally defined file descriptor is problematic (however it is the norm in the libtracer_tool.so library in ROCTracer) rather than passing it through arguments, the wrapping flushing function can be modified to take a void pointer. The file descriptor can then be passed through this pointer and be used in the default flushing function.
    yoann-heitz committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    2b0aab5 View commit details
    Browse the repository at this point in the history
  2. Isolate flushing instructions for kernel events

    Isolated flushing instructions into a wrapping function. The file descriptor used for flushing is the one that is globally defined and not the one stored in the context_entry_t object as it is always the one that is defined globally that is used. If using a globally defined file descriptor is problematic (however it is the norm in the libtracer_tool.so library in ROCTracer) rather than passing it through arguments, the wrapping flushing function can be modified to take a void pointer. The file descriptor can then be passed through this pointer and be used in the default flushing function.
    yoann-heitz committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    5ccee80 View commit details
    Browse the repository at this point in the history