Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve null test coverage #519

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Naraenda
Copy link
Member

@Naraenda Naraenda commented Jul 9, 2024

This PR improve the coverage of the neg_test by also testing more generate_* functions.

@Naraenda Naraenda marked this pull request as ready for review July 9, 2024 09:36
@Naraenda Naraenda mentioned this pull request Jul 9, 2024
@Naraenda Naraenda self-assigned this Jul 10, 2024
@Naraenda
Copy link
Member Author

@rponnuru5 @stanleytsang-amd Can we merge this and close #492?

@stanleytsang-amd
Copy link
Collaborator

@rponnuru5 @stanleytsang-amd Can we merge this and close #492?

Sorry for the delay - running CI on this now. There seems to be some issues with our CI. I'll keep you posted.

@stanleytsang-amd stanleytsang-amd merged commit 76d16a5 into ROCm:develop Aug 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants