ffmpeg software decoder implementation #461
Open
+1,205
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiritigowda
added
enhancement
spolifroni-amd
approved these changes
Nov 26, 2024
| @@ -203,18 +214,26 @@ int main(int argc, char **argv) { | |||
| try { | |||
| std::size_t found_file = input_file_path.find_last_of('/'); | |||
| std::cout << "info: Input file: " << input_file_path.substr(found_file + 1) << std::endl; | |||
| RocVideoDecoder *viddec; | |||
There was a problem hiding this comment.
can we initialize to nullptr?
| if (av_packets_.empty()) { | ||
| for (int i=0; i < num_decode_surfaces; i++) { | ||
| AVPacket *pkt = av_packet_alloc(); | ||
| pkt->data = static_cast<u_int8_t *> (av_packet_data_[i].first); |
There was a problem hiding this comment.
did you mean uint8_t? Not sure what u_int8_t is.
|
|
||
| surface_stride_ = target_width_ * byte_per_pixel_; | ||
| chroma_height_ = static_cast<int>(std::ceil(target_height_ * GetChromaHeightFactor(video_surface_format_))); | ||
| chroma_width_ = (int)(ceil(target_width_ * GetChromaWidthFactor(video_surface_format_))); |
There was a problem hiding this comment.
please use static_cast here
| AVPacket *pkt; | ||
| do { | ||
| pkt = PopPacket(); | ||
| //std::cout << "pop packet" << std::endl; |
There was a problem hiding this comment.
remove comment if unnecessary
| while (status >= 0) { | ||
| status = avcodec_receive_frame(dec_context_, p_frame); | ||
| if (status == AVERROR(EAGAIN) || status == AVERROR_EOF) { | ||
| //av_frame_free(&p_frame); |
There was a problem hiding this comment.
remove line if unnecessary
| if (dec_context_->frame_number == 1) { | ||
| InitOutputFrameInfo(p_frame); | ||
| } | ||
| //std::cout<<"Decoding frame: " << dec_context_->frame_number << "<pframe, index>: " << p_frame << " " << av_frame_cnt_ << std::endl; |
There was a problem hiding this comment.
remove line if unnecessary
|
|
||
| /** | ||
| * @brief This function is used to get the current frame size based on pitch | ||
| */ | ||
| int GetFrameSizePitched() { assert(surface_stride_); return surface_stride_ * (disp_height_ + (chroma_height_ * num_chroma_planes_)); } | ||
| //int GetFrameSizePitched() { assert(surface_stride_); return surface_stride_ * (disp_height_ + (chroma_height_ * num_chroma_planes_)); } |
There was a problem hiding this comment.
why is this commented out?
| parser_params.clock_rate = clk_rate; | ||
| parser_params.max_display_delay = disp_delay_; | ||
| parser_params.user_data = this; | ||
| parser_params.pfn_sequence_callback = FFMpegVideoDecoder::FFMpegHandleVideoSequenceProc; |
There was a problem hiding this comment.
can we call the functions directly since it's member functions of the same class. Do we need the scope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented ffmpeg based software decoder
Modified videoDecode sample to allow ffmpeg based decoding