Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CMake to respect GPU_TARGETS variable #257

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lawruble13
Copy link
Contributor

Summary of proposed changes:

  • Change the CMake to set the GPU_TARGETS variable from AMDGPU_TARGETS if not set by the user
  • Change all usages of AMDGPU_TARGETS to GPU_TARGETS

@@ -109,6 +109,8 @@ else()
)
endif()
set(AMDGPU_TARGETS "${DEFAULT_AMDGPU_TARGETS}" CACHE STRING "List of specific machine types for library to target")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can also remove AMDGPU_TARGETS?

Copy link
Contributor

@jsandham jsandham Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are supposed to continue supporting AMDGPU_TARGETS but just issue a deprecation warning saying to use GPU_TARGETS. I think we want to add something like what rocblas did, i.e. delete the above line and add this instead:

if( AMDGPU_TARGETS AND NOT GPU_TARGETS )
message( DEPRECATION "AMDGPU_TARGETS use is deprecated. Use GPU_TARGETS." )
set( GFX_LIST ${AMDGPU_TARGETS} )
elseif( GPU_TARGETS )
set( GFX_LIST ${GPU_TARGETS} )
else ()
set( GFX_LIST ${DEFAULT_AMDGPU_TARGETS} ) # default if not set
endif()

set(GPU_TARGETS "${GFX_LIST}" CACHE STRING "GPU architectures to build for")

eidenyoshida pushed a commit that referenced this pull request Nov 20, 2024
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.4.0 to 1.4.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants