[MIGraphX EP] Set external data path option #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apwojcik
requested changes
Jul 1, 2024
| @@ -100,6 +101,7 @@ class MIGraphXExecutionProvider : public IExecutionProvider { | |||
| migraphx::target t_; | |||
| OrtMutex mgx_mu_; | |||
| hipStream_t stream_ = nullptr; | |||
| mutable char model_path_[4096] = {}; // Reserved for max path length | |||
There was a problem hiding this comment.
Please change it to std::filesystem::path or std::string. Your assumption about the max path needs to be corrected -NTFS can have paths up to 64K characters.
apwojcik
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set external data path before calling parse_onnx_buffer in case MIGraphX needs to read external data.
This change is needed in order for ORT Stable Diffusion pipeline (maybe some other models as well) to work with MIGraphX EP. It fails to compile unet model because it does not construct absolute path to the external file that is needed for compilation.
Note: This change depends on changes in AMDMIGraphX (PR: ROCm/AMDMIGraphX#3191)