Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embed library option #1403

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions tensilelite/Tensile/TensileCreateLibrary.py
Original file line number Diff line number Diff line change
Expand Up @@ -1274,11 +1274,6 @@ def splitExtraParameters(par):
help="Include logic files in directories named 'Experimental'.")
argParser.add_argument("--no-enumerate", action="store_true", help="Do not run rocm_agent_enumerator.")
argParser.add_argument("--package-library", dest="PackageLibrary", action="store_true", default=False)
argParser.add_argument("--embed-library", dest="EmbedLibrary",
help="Embed (new) library files into static variables. Specify the name of the library.")

argParser.add_argument("--embed-library-key", dest="EmbedLibraryKey", default=None,
help="Access key for embedding library files.")
argParser.add_argument("--version", help="Version string to embed into library file.")
argParser.add_argument("--generate-manifest-and-exit", dest="GenerateManifestAndExit", action="store_true",
default=False, help="Output manifest file with list of expected library objects and exit.")
Expand Down Expand Up @@ -1343,7 +1338,6 @@ def splitExtraParameters(par):
arguments["ShortNames"] = args.ShortNames
arguments["LibraryPrintDebug"] = args.LibraryPrintDebug
arguments["CodeFromFiles"] = False
arguments["EmbedLibrary"] = args.EmbedLibrary
arguments["LogicFormat"] = args.LogicFormat
arguments["LibraryFormat"] = args.LibraryFormat
if args.no_enumerate:
Expand Down Expand Up @@ -1532,18 +1526,6 @@ def validLogicFile(p: Path):
if globalParameters["PackageLibrary"] or globalParameters["SeparateArchitectures"]:
theMasterLibrary = list(masterLibraries.values())[0]

if args.EmbedLibrary is not None:
embedFileName = os.path.join(outputPath, "library/{}.cpp".format(args.EmbedLibrary))
with EmbeddedData.EmbeddedDataFile(embedFileName) as embedFile:

ext = ".yaml" if globalParameters["LibraryFormat"] == "yaml" else ".dat"
embedFile.embed_file(theMasterLibrary.cpp_base_class, masterFile + ext, nullTerminated=True,
key=args.EmbedLibraryKey)

for co in Utils.tqdm(codeObjectFiles):
embedFile.embed_file("SolutionAdapter", co, nullTerminated=False,
key=args.EmbedLibraryKey)

if args.BuildClient:
print1("# Building Tensile Client")
ClientExecutable.getClientExecutable(outputPath)
Expand Down