Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/187: update account after updating transaction #188

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coluzziandrea
Copy link
Contributor

Currently The account is not updated after changes in transations.

This PR will:

  • Add an updateAccount method inside the add_page view
  • Add call to updateAccount when creating or updating transaction
  • Add call to updateAccount when removing transaction

Closes #187

prova.mp4

@theperu theperu added the bug Something isn't working label Dec 27, 2024
@theperu theperu added this to the 1.0 Stable milestone Dec 27, 2024
@theperu theperu self-requested a review January 4, 2025 14:11
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the contribution, can you specify what device did you use to test your changes?
I tried them and I see the same behavior as before both using a Xiaomi and an emulated Pixel 7 with the latest version of Android
Video: https://drive.google.com/file/d/1qtV6usVIRUjE2PnaXg_x2taNq5X0MkCN/view?usp=sharing

@coluzziandrea
Copy link
Contributor Author

@theperu very strange! I did test on emulated pixel 6a with android 34, I'll try with the latest one!

@coluzziandrea
Copy link
Contributor Author

@theperu i think i found the issue PTAL

Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it seems to be working as expected ✅
Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accounts amount is not updated after adding a transaction
2 participants