Fix: Warning solved + Notifications + Package renamed #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update project package name from com.example.sossoldi to com.ripsters.sossoldi
theperu
requested changes
Nov 23, 2024
There was a problem hiding this comment.
Great job! I have left just one comment on a doubt that I have. I also noticed that the app version seems to be set to 1.0.0 but since we are releasing a beta I think it would be best to set it to 0.1.0 in order to better convey the idea that we are still working on it.
| @@ -45,7 +44,7 @@ class _AmountSectionState extends ConsumerState<AmountSection> with Functions { | |||
| Widget build(BuildContext context) { | |||
| final trsncTypeList = ref.watch(transactionTypeList); | |||
| final selectedType = ref.watch(transactionTypeProvider); | |||
| final currencyState = ref.watch(currencyStateNotifier); | |||
| // final currencyState = ref.watch(currencyStateNotifier); | |||
There was a problem hiding this comment.
Why did you commented out this line?
There was a problem hiding this comment.
This was unused, maybe could just be removed.
- Downgrade the app version from 1.0.0 to 0.1.0 for the beta - Reintroduce the recurring transactions list with some ui improvements
|
Seems good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited a lot of file to fix new warnings, but without major breaking changes.
This PR also implemented: