Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurrencySelector #70 #153

Merged
merged 6 commits into from
Feb 25, 2024
Merged

CurrencySelector #70 #153

merged 6 commits into from
Feb 25, 2024

Conversation

K-w-e
Copy link
Contributor

@K-w-e K-w-e commented Feb 12, 2024

I managed the currency selection.
I created a basic provider.
Then, obtaining the value through it, I display the selected currency within the application.
Additionally, some StatelessWidget have been converted to ConsumerWidget just to read the selected currency value.

Feel free to provide any suggestions or requests for modifications!

jackrua
jackrua reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jackrua jackrua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful job! this currency thing it's something I had on my issue list for a while. Tried this PR on my phone and it seems that everything works as it should.

Just to be pedantic, my Editor tells me that this is an unused import.

lib/providers/currency_provider.dart Outdated Show resolved Hide resolved
theperu
theperu approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@theperu theperu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to do this, it was probably quite boring 😅
It seems to be working as expected and I think we can merge

@lucaantonelli lucaantonelli merged commit 894dec8 into RIP-Comm:main Feb 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackrua jackrua jackrua left review comments

@theperu theperu theperu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@K-w-e @theperu @jackrua @lucaantonelli