Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BG2 #222

Merged
merged 6 commits into from
Feb 18, 2024
Merged

Support BG2 #222

merged 6 commits into from
Feb 18, 2024

Conversation

AlessioC31
Copy link
Collaborator

@AlessioC31 AlessioC31 commented Feb 16, 2024 •
edited
Loading

  • Moved registers and memory of LCD into appropriate structs
  • Added basic support for BG2
  • Fixed interrupt handler

Now if we run the Thumb tests we have:

image

🎉

guerinoni
guerinoni approved these changes Feb 18, 2024
View reviewed changes
Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, it would be nice to add some reference in readme or in comment where those things are written but we can do this later aslo

@guerinoni guerinoni added this pull request to the merge queue Feb 18, 2024
Merged via the queue into RIP-Comm:main with commit b020dc6 Feb 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guerinoni guerinoni guerinoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlessioC31 @guerinoni