Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blockmemory #220

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Fix blockmemory #220

merged 2 commits into from
Jan 3, 2024

Conversation

AlessioC31
Copy link
Collaborator

  • Thumb: Correctly handles base in register list for multiple load/store
    This commit fixes thumb tests 230,231,232.
  • Thumb: Correctly emulates undefined behavior when register list is empty in block load/store
    This should never happen but test rom has a test for it.
    This commit fixes tests 227 and 229.

@AlessioC31
Thumb: Correctly emulates undefined behavior when register list is em…
9bc9a22 
…pty in block load/store

This should never happen but test rom has a test for it.
This commit fixes tests 227 and 229.
@AlessioC31 AlessioC31 requested a review from guerinoni January 3, 2024 02:03
guerinoni
guerinoni approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice found!

@guerinoni guerinoni added this pull request to the merge queue Jan 3, 2024
Merged via the queue into RIP-Comm:main with commit 7c39cd6 Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guerinoni guerinoni guerinoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlessioC31 @guerinoni