Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create logger and disassembler feature default disabled #214

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Create logger and disassembler feature default disabled #214

merged 6 commits into from
Sep 21, 2023

Conversation

guerinoni
Copy link
Collaborator

@guerinoni guerinoni commented Sep 21, 2023 •
edited
Loading

  • Just: Remove useless cmds
  • Just: Add quick cmd for run rom
  • Logger: Make logger a feature opt-in
  • Doc: Update README
  • UI: Make disassambler a feature opt-in

Those are the 3 different perf with no feature, logger and disassembler
flamegraph

flamegraph1

flamegraph0

@guerinoni
Just: Remove useless cmds
c6f95dd 
Signed-off-by: Federico Guerinoni <[email protected]>
@guerinoni
Just: Add quick cmd for run rom
a4cc14b 
Signed-off-by: Federico Guerinoni <[email protected]>
@guerinoni
Logger: Make logger a feature opt-in
6b22ac5 
In this way we can skip if we don't care about logger, and we can enable
with a simple cmd using just for log on stdout or file.

Signed-off-by: Federico Guerinoni <[email protected]>
@guerinoni
Doc: Update README
07ead9f 
Signed-off-by: Federico Guerinoni <[email protected]>
@guerinoni guerinoni self-assigned this Sep 21, 2023
@guerinoni
UI: Make disassambler a feature opt-in
9df0eaa 
In this way we can skip the slow part of formatting ASM in the widget if
we don't care about it.

Signed-off-by: Federico Guerinoni <[email protected]>
@guerinoni
CI: Improve workflow using just for keeping commands in one place
6fba3d1 
Signed-off-by: Federico Guerinoni <[email protected]>
AlessioC31
AlessioC31 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@AlessioC31 AlessioC31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@guerinoni guerinoni added this pull request to the merge queue Sep 21, 2023
Merged via the queue into main with commit f671635 Sep 21, 2023
3 checks passed
@guerinoni guerinoni deleted the feature-debugging branch September 21, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlessioC31 AlessioC31 AlessioC31 approved these changes

Assignees

@guerinoni guerinoni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guerinoni @AlessioC31