ws281x: Use static inline function through inline namespace #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Teufelchen1
approved these changes
Apr 15, 2024
chrysn
added a commit
to MrKevinWeiss/RIOT
that referenced
this pull request
Apr 15, 2024
This pulls in [88], and thus fixes building of Rust modules when the wS281x module is enabled. [88]: RIOT-OS/rust-riot-wrappers#88
ant9000
pushed a commit
to ant9000/RIOT
that referenced
this pull request
Aug 23, 2024
This pulls in [88], and thus fixes building of Rust modules when the wS281x module is enabled. [88]: RIOT-OS/rust-riot-wrappers#88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unblocks: RIOT-OS/RIOT#20562
The module probably got broken when the inline functions were not automatically exported to the main namespace any more. Now that 20562 enables it on default boards, it is built the first time since 2021, and can now be built again.
There is no standalone test for this yet; it can be tested from RIOT by bending .cargo/config.toml to this branch, and running
USEMODULE+=ws281x make -C examples/rust-gcoap BOARD=microbit-v2(which failed to build before, and now builds).