tests/sys/shell: use default terminal instead of socat #21058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
tests/sys/shell
currently per default usessocat
as terminal, according to the comment to avoid having extra characters put into the IO by the terminal program. But that's exactly whatmake cleanterm
is for, which is already used per default by the python testrunner.I encountered issues with
socat
for this test (newlines not properly matched against) on boards that useusb_cdc_acm
as stdio, while the approach withcleanterm
works as expected.Testing procedure
Run the test with some boards using
make -C tests/sys/shell BOARD=xxx flash test
. Successfully tested withnative
,nrf52840dk
andfeather-nrf52840-sense
.Issues/PRs references
The commit cdfece6 that introduced the change was merged one and a half months before the introduction of the
cleanterm
target in #12107