Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/sys/shell: use default terminal instead of socat #21058

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mguetschow
Copy link
Contributor

Contribution description

tests/sys/shell currently per default uses socat as terminal, according to the comment to avoid having extra characters put into the IO by the terminal program. But that's exactly what make cleanterm is for, which is already used per default by the python testrunner.

I encountered issues with socat for this test (newlines not properly matched against) on boards that use usb_cdc_acm as stdio, while the approach with cleanterm works as expected.

Testing procedure

Run the test with some boards using make -C tests/sys/shell BOARD=xxx flash test. Successfully tested with native, nrf52840dk and feather-nrf52840-sense.

Issues/PRs references

The commit cdfece6 that introduced the change was merged one and a half months before the introduction of the cleanterm target in #12107

python tests by default already use make cleanterm
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 2, 2024
@maribu maribu added CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: full build disable CI build filter CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: full build disable CI build filter CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants