Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/core/cond_order/: calling cond signal and broadcast without waiting threads #21030

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

JulianHolzwarth
Copy link
Contributor

Contribution description

Through test coverage, I noticed the test never tried the functions cond_signal and cond_broadcast without a thread waiting. This change helps to find problems with the functions when no thread is waiting.

Testing procedure

BOARD=native make -C tests/core/cond_order flash test
check test coverage before and after (I used simple coverage of thread communication)

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Nov 22, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Nov 22, 2024
@riot-ci
Copy link

riot-ci commented Nov 22, 2024

Murdock results

✔️ PASSED

1ed2f36 tests/cond_order/main.c: testing without waiting threads

Success Failures Total Runtime
22 0 23 01m:44s

Artifacts

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM! I'll trust CI for testing.

@mguetschow mguetschow added this pull request to the merge queue Nov 25, 2024
@maribu maribu removed this pull request from the merge queue due to a manual request Nov 26, 2024
@maribu maribu added this pull request to the merge queue Nov 26, 2024
@maribu
Copy link
Member

maribu commented Nov 26, 2024

I toggled the merge queue to prevent a timeout. The nightly build is still in front of this PR, but is done in about 2h. So this should pass now before the 360 min timeout is hit.

Merged via the queue into RIOT-OS:master with commit b69d060 Nov 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants