drivers/mtd_flashpage: Should fail on compilation if slot_aux is used while feature is not present #20557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfessel
added
CI: ready for build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
since
CONFIG_SLOT_AUX_LENis only supported on platforms whereMODULE_PERIPH_FLASHPAGE_AUXis provided, it should also only successfuly compile on those platforms. Thats not the case right now, as there only is a check ifCONFIG_SLOT_AUX_LENis defined. This PR makes sure we fail the compilation if we haveCONFIG_SLOT_AUX_LENwithoutMODULE_PERIPH_FLASHPAGE_AUXTesting procedure
Compile the tests/drivers/mtd_flashpage without the
#ifdef MODULE_PERIPH_FLASHPAGE_AUXs and check that it failsIssues/PRs references