-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unittests: Move at test to driver tests #20540
Conversation
you are right even thought the test itself does not make use of the uart the driver/at that it tests depend on it @derMihai might have some thoughts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's weird that there is a device involved that just gets turned off, but aparently that's how at_dev_init works (can't pass it the none-device), but that's beyond the scope of fixing it.
I don't know the precise workings of the AT module or this test, but as the test passes (doing things) for you, I think it's good.
C is such a magic. A test that compiles and runs fine on my machine, suddenly misses a header on the CI. |
Fixup passed. Let's try if I can force push too (not sure it really worked); at any rate, I'll let you do the merge pushing so you confirm my one-line addition. |
Ah, please update the Makefile.ci with the |
This'll need Makefile.ci, building it already. |
(maybe even more, but the full build stopped there) |
This PR does break a few things, see #20551. |
Contribution description
Hi 🦜
This moves the unit test for the at driver into the folder for driver tests. The test accesses/depends on hardware which is not valid for a unit test.
Further, the original test disabled
UART_DEV(0)
which I changed toUART_DEV(1)
. This is needed as some boards use device zero for stdio and you can not have a good testing experience without stdio.Please provide feedback on this workaround, I am unsure on the quality of it.
Testing procedure
Running
make -C tests/drivers/at_unit/ all flash
should provide this output upon success:Issues/PRs references
Introduced in commit 63e057c by PR #20423