-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release 3.4.4 #864
release 3.4.4 #864
Conversation
Changed stringrefs to coderefs
Cange string sub references to realcoderefs
some operator fixes #835
Fixed some operators
Fixed some operators
Fixed some operators
…to dev-r34_operatorFixes
fixes operator #836
…to dev-r34_operatorFixes
Fix compare against string
tests revised to Test2
Dev r34 operator fixes
* Update 14_SD_UT.pm
* SD_UT new attribute UTfrequency for individual transmission frequency Multiple query "$ attrName eq 'model'" removed change commandref replace "foreach my $keys (keys %models)" with "if ( exists $models{$attrValue}" in line 1756 replace "foreach my $keys (sort keys %{$models{RC_10}{buttons}})" with "if ( exists $models{RC_10}{buttons}{$button} )" in line 1845 replace "foreach my $keys (keys %models)" with "grep { $models{$_}{hex_lengh} =~ /$hex_lengh/ } keys %models;" in line 1745 delete "$attr{$name}{room} = "SD_UT" if( not defined( $attr{$name}{room} ) );" change search for models with same hex_length
* Update 14_SD_UT.pm If the device is created manually with IODev, then DEF is wrong.
* 00_SIGNALduino.pm Fix some perlcritic 5 warnings
So damit, der Sprung für 3.5 nicht so groß wird, habe ich die 3.4.4 vorbereitet. |
Pull Request Test Coverage Report for Build 3520
💛 - Coveralls |
OK |
Hallo @sidey79, Die die Modul Version 3.4.4 https://github.com/RFD-FHEM/RFFHEM/releases als Release markiert ist, so können wir doch die dev-r3.5 als Pre-Release einstufen wo wir die kommenden Entwicklungen ergänzen. Oder wie hast du dir das gedacht? Parallel wäre es günstig, die Firmware Version 3.4.0-dev+20200711 als Release zu markieren (https://github.com/RFD-FHEM/SIGNALDuino/releases) um mit 3.4 zu 3.4 gleich zu bleiben. Achso, die 3.4 könntest du dann in den Master schieben. @elektron-bbs, entspricht dies auch deinen Vorstellungen? |
Die Releases beziehen sich immer auf einen commit und stellen quasi einen Schnappschuss dar. Bei der Firmware ist es eigentlich egal ob diese die gleiche Versionsnummer wie das Modul hat. |
Das würde meiner Meinung erst Sinn machen, auf diesen #866 Commit.
Nein, bisher sind keine Probleme bekannt. Im Gegenteil, wir haben ja mit diem RFD-FHEM/SIGNALDuino@72c9e25 einen Fix behoben. Somit könntest du den Stand RFD-FHEM/SIGNALDuino@74fa948 als "Cut" übernehmen. |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
00_SIGNALduino.pm
Fix some perlcritic 5 warnings
some operator fixes Wrong operator for eq 00_SIGNALduino #835
Changed stringrefs to coderefs
10_FS10
revised for perlcritic
10_SD_GT
revised for perlcritic (#847)
14_SD_UT.pm
add attribute UTfrequency in (add attribute UTfrequency in 14_SD_UT.pm #845)
new attribute UTfrequency for individual transmission frequency
Multiple query "$ attrName eq 'model'" removed
change commandref
replace "foreach my $keys (keys %models)" with "if ( exists $models{$attrValue}" in line 1756
replace "foreach my $keys (sort keys %{$models{RC_10}{buttons}})" with "if ( exists $models{RC_10}{buttons}{$button} )" in line 1845
replace "foreach my $keys (keys %models)" with "grep { $models{$_}{hex_lengh} =~ /$hex_lengh/ } keys %models;" in line 1745
delete "$attr{$name}{room} = "SD_UT" if( not defined( $attr{$name}{room} ) );"
change search for models with same hex_length
Reference to autocreate added
rename hex_lengh in hex_length
Check values attribute UTfrequency added
Documentation for UTfrequency attribute added
SD_ProtocolData.pm
new protocol 104 for remote control TR60C-1 (#844)
new protocol 99 NAVARIS touch light switch (#841)
new protocol 98 for wireless door bell GEA-028DB (#839)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no