Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 00_SIGNALduino.pm - fix pattern #782 #798

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

HomeAutoUser
Copy link
Contributor

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added / modified (needed for for bug fixes / features)
  • commandref has been added / updated (needed for bug fixes / features)
  • CHANGED has been updated (needed for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • Pattern can have decimal places
  • What is the new behavior (if this is a feature change)?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2643

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 5 files lost coverage.
  • Overall coverage remained the same at 53.463%

Files with Coverage Reduction New Missed Lines %
FHEM/00_SIGNALduino.pm 1 76.16%
FHEM/10_FS10.pm 1 6.15%
FHEM/14_SD_WS09.pm 1 69.74%
FHEM/14_SD_WS_Maverick.pm 1 7.14%
FHEM/41_OREGON.pm 1 2.0%
Totals Coverage Status
Change from base Build 2642: 0.0%
Covered Lines: 3227
Relevant Lines: 6036

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 23, 2020

Pull Request Test Coverage Report for Build 2643

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.463%

Totals Coverage Status
Change from base Build 2642: 0.0%
Covered Lines: 3227
Relevant Lines: 6036

💛 - Coveralls

@sidey79
Copy link
Contributor

sidey79 commented Feb 23, 2020

Ich habe dazu eine Frage / Anregung:

Ich habe verstanden, dass wir ein Problem mit Nachkommastellen haben.
Die müssen weg, das ist soweit klar, aber sollen die einfach abgeschnitten werden oder mathematisch gerundet?

@HomeAutoUser
Copy link
Contributor Author

Ich denke mal ob runden oder abschneiden macht keinen Unterschied.
Ob wir nun 1245.3 zu 1245 oder 1246 machen. So gering ist ja die Toleranzschwelle nicht. Selbst 50.5 würde 50 oder 51 ergeben. Solche Unterschiede von 1 verarbeiten wir doch eh nicht so „klein“.

@sidey79
Copy link
Contributor

sidey79 commented Feb 23, 2020

Ja, so genau muss es nicht sein, da gebe ich dir Recht. Ich wollte nur darauf hinweis, damit wir uns nicht später wundern, wenn 254,99 dann nur 254 und nicht 255 sind :)

@HomeAutoUser HomeAutoUser merged commit d6b0822 into RFD-FHEM:dev-r34 Feb 23, 2020
@HomeAutoUser HomeAutoUser deleted the dev-r34_sendmsg_bug branch February 23, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants